Skip to content

[WIP] Fix customServiceConfig bug <Jira: OSPRH-10696>#566

Closed
mumesan wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
mumesan:fix_custom_service_config_bug_OSPRH-10696
Closed

[WIP] Fix customServiceConfig bug <Jira: OSPRH-10696>#566
mumesan wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
mumesan:fix_custom_service_config_bug_OSPRH-10696

Conversation

@mumesan
Copy link
Copy Markdown
Contributor

@mumesan mumesan commented Jun 20, 2025

This fixes a bug where changes to the customServiceConfig at the ironic level did not propagate to ironic-api or ironic-conductor.
It is expected that it is not supposed to change the behaviour of ironic-inspector or ironic-neutron-agent.

Jira: OSPRH-10696

@openshift-ci openshift-ci bot requested review from olliewalsh and steveb June 20, 2025 11:32
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mumesan
Once this PR has been reviewed and has the lgtm label, please assign steveb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Jun 20, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d38dec7f472f4c7ca699bd38e012f9e5

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 19m 18s
❌ podified-multinode-ironic-deployment FAILURE in 57m 40s

@mumesan mumesan force-pushed the fix_custom_service_config_bug_OSPRH-10696 branch from 2a254aa to 838cb17 Compare June 23, 2025 13:18
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Jun 23, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/790ec580cabc40ffa9953a1013fb6576

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 19m 01s
❌ podified-multinode-ironic-deployment FAILURE in 59m 28s

@mumesan mumesan force-pushed the fix_custom_service_config_bug_OSPRH-10696 branch from 838cb17 to a5057bf Compare June 23, 2025 15:36
@mumesan mumesan changed the title Fix customServiceConfig bug <Jira: OSPRH-10696> [WIP] Fix customServiceConfig bug <Jira: OSPRH-10696> Jun 23, 2025
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Jun 23, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7db30bec96dc4e439eb403c8f24b1881

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 17m 29s
❌ podified-multinode-ironic-deployment FAILURE in 56m 59s

@mumesan mumesan force-pushed the fix_custom_service_config_bug_OSPRH-10696 branch from a5057bf to e132a75 Compare June 26, 2025 09:29
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Jun 26, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/42c6acc7ee3f4537bb310dd53347b89a

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 20m 00s
❌ podified-multinode-ironic-deployment FAILURE in 57m 46s

@mumesan mumesan force-pushed the fix_custom_service_config_bug_OSPRH-10696 branch 4 times, most recently from 3d14d40 to 0d6bfa8 Compare June 27, 2025 16:24
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Jun 27, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fbb8534a5227448bb6b2717289d632bf

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 16m 39s
❌ podified-multinode-ironic-deployment FAILURE in 56m 01s

@mumesan mumesan force-pushed the fix_custom_service_config_bug_OSPRH-10696 branch from 0d6bfa8 to 9b43ae2 Compare June 30, 2025 15:39
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Jun 30, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e483f6b497da456585e11d48571e9ba7

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 16m 47s
❌ podified-multinode-ironic-deployment FAILURE in 56m 26s

@mumesan mumesan force-pushed the fix_custom_service_config_bug_OSPRH-10696 branch 2 times, most recently from c0b2a27 to 1fa3b5f Compare July 2, 2025 09:23
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Jul 2, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/55f84029748e4c8cb4820a941f080954

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 18m 57s
❌ podified-multinode-ironic-deployment FAILURE in 55m 05s

@mumesan mumesan force-pushed the fix_custom_service_config_bug_OSPRH-10696 branch from 1fa3b5f to 9dd54ec Compare July 2, 2025 12:33
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Jul 2, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4ec2a6dd16e34339b85516ae5090ca86

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 19m 31s
❌ podified-multinode-ironic-deployment FAILURE in 56m 46s

@mumesan mumesan force-pushed the fix_custom_service_config_bug_OSPRH-10696 branch from 9dd54ec to b60fcc9 Compare July 2, 2025 16:11
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Jul 2, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d549362b1174433880e4a00b847098b7

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 21m 26s
❌ podified-multinode-ironic-deployment FAILURE in 58m 37s

@mumesan mumesan force-pushed the fix_custom_service_config_bug_OSPRH-10696 branch from b60fcc9 to 0a7b2c4 Compare July 3, 2025 05:47
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Jul 3, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/df6473f97fb84b4384f58d3fa076d0aa

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 16m 10s
❌ podified-multinode-ironic-deployment FAILURE in 56m 25s

@mumesan mumesan force-pushed the fix_custom_service_config_bug_OSPRH-10696 branch 2 times, most recently from 076373a to 0af2d19 Compare July 3, 2025 07:57
@mumesan mumesan force-pushed the fix_custom_service_config_bug_OSPRH-10696 branch from 0af2d19 to c85e78b Compare July 3, 2025 08:09
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Jul 3, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fc286e7732364a2583f40e99ce67abb5

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 16m 56s
❌ podified-multinode-ironic-deployment FAILURE in 57m 10s

@mumesan mumesan force-pushed the fix_custom_service_config_bug_OSPRH-10696 branch from c85e78b to 1187751 Compare July 3, 2025 09:49
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Jul 3, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/721038bac7bb4da08bdd30df8097544f

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 18m 51s
❌ podified-multinode-ironic-deployment FAILURE in 59m 17s

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 3, 2025

@mumesan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ironic-operator-build-deploy-kuttl 1187751 link true /test ironic-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Copy Markdown
Collaborator

openshift-merge-robot commented Jul 4, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mumesan mumesan closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

@steveb steveb Awaiting requested review from steveb

Assignees

No one assigned

Labels

do-not-merge/work-in-progress needs-rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mumesan @openshift-merge-robot